admin/ReadKeep
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: Add explicit width constraint to headerView in BookmarkDetailView2

Browse Source 
Changed headerView from var to func with width parameter, matching LegacyView.
Added .frame(width: width, height: headerHeight) to constrain header image width.

This was the root cause of content overflow - without explicit width on the
header image, the entire ZStack and its children (including title and webview)
could grow beyond viewport width. Now matches LegacyView implementation exactly.
This commit is contained in:
Ilyas Hallak 2025-10-10 20:23:38 +02:00
parent 4c744e6d10
commit 4595a9b69f
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
readeck/UI/BookmarkDetail/BookmarkDetailView2.swift
View File

@ -101,7 +101,7 @@ struct BookmarkDetailView2: View {
VStack(spacing: 0) {
ZStack(alignment: .top) {
headerView
headerView(width: geometry.size.width)
VStack(alignment: .leading, spacing: 16) {
Color.clear.frame(width: geometry.size.width, height: viewModel.bookmarkDetail.imageUrl.isEmpty ? 84 : headerHeight)
@ -234,12 +234,12 @@ struct BookmarkDetailView2: View {
// MARK: - ViewBuilder
@ViewBuilder
private var headerView: some View {
private func headerView(width: CGFloat) -> some View {
if !viewModel.bookmarkDetail.imageUrl.isEmpty {
ZStack(alignment: .bottomTrailing) {
CachedAsyncImage(url: URL(string: viewModel.bookmarkDetail.imageUrl))
.aspectRatio(contentMode: .fill)
.frame(height: headerHeight)
.frame(width: width, height: headerHeight)
.clipped()
// Zoom icon
@ -262,7 +262,7 @@ struct BookmarkDetailView2: View {
.padding(.trailing, 16)
.padding(.bottom, 16)
}
.frame(height: headerHeight)
.frame(width: width, height: headerHeight)
.ignoresSafeArea(edges: .top)
.onTapGesture {
showingImageViewer = true