From a651398dcaca8a30975822ce5672459286fa9686 Mon Sep 17 00:00:00 2001 From: Ilyas Hallak Date: Wed, 1 Oct 2025 21:56:50 +0200 Subject: [PATCH] fix: Revert to working tabItem syntax due to compiler error - Revert Tab() syntax that caused compiler diagnostic error - Use proven .tabItem approach that works reliably - Keep modern Label() components for better accessibility - Maintain all functionality while ensuring compilation success --- readeck/UI/Menu/PhoneTabView.swift | 30 +++++++++++++++++------------- 1 file changed, 17 insertions(+), 13 deletions(-) diff --git a/readeck/UI/Menu/PhoneTabView.swift b/readeck/UI/Menu/PhoneTabView.swift index 9411be2..b5a5060 100644 --- a/readeck/UI/Menu/PhoneTabView.swift +++ b/readeck/UI/Menu/PhoneTabView.swift @@ -34,26 +34,30 @@ struct PhoneTabView: View { @ViewBuilder private var mainTabsContent: some View { ForEach(Array(mainTabs.enumerated()), id: \.element) { idx, tab in - Tab(tab.label, systemImage: tab.systemImage, value: idx) { - tabView(for: tab) - } + tabView(for: tab) + .tabItem { + Label(tab.label, systemImage: tab.systemImage) + } + .tag(idx) } } @ViewBuilder private var moreTabContent: some View { - Tab("More", systemImage: "ellipsis", value: mainTabs.count) { - VStack(spacing: 0) { - moreTabsList - moreTabsFooter - } - .onAppear { - if selectedTabIndex == mainTabs.count && selectedMoreTab != nil { - selectedMoreTab = nil - } - } + VStack(spacing: 0) { + moreTabsList + moreTabsFooter + } + .tabItem { + Label("More", systemImage: "ellipsis") } .badge(offlineBookmarksViewModel.state.localBookmarkCount > 0 ? offlineBookmarksViewModel.state.localBookmarkCount : 0) + .tag(mainTabs.count) + .onAppear { + if selectedTabIndex == mainTabs.count && selectedMoreTab != nil { + selectedMoreTab = nil + } + } } @ViewBuilder