From b9296114308fc4d70216fad2a93ad98c9e85f90c Mon Sep 17 00:00:00 2001
From: Christian Putzke <christian@putzke.de>
Date: Fri, 26 Sep 2025 20:45:38 +0200
Subject: [PATCH] Code review fixes

---
 readeck/Domain/Model/UrlOpener.swift               | 2 --
 readeck/Localizations/de.lproj/Localizable.strings | 3 +++
 readeck/UI/Settings/SettingsGeneralView.swift      | 4 ++--
 3 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/readeck/Domain/Model/UrlOpener.swift b/readeck/Domain/Model/UrlOpener.swift
index 5189b6b..59b9b01 100644
--- a/readeck/Domain/Model/UrlOpener.swift
+++ b/readeck/Domain/Model/UrlOpener.swift
@@ -1,5 +1,3 @@
-import SwiftUI
-
 enum UrlOpener: String, CaseIterable {
     case inAppBrowser = "inAppBrowser"
     case defaultBrowser = "defaultBrowser"
diff --git a/readeck/Localizations/de.lproj/Localizable.strings b/readeck/Localizations/de.lproj/Localizable.strings
index 0532213..25a4a98 100644
--- a/readeck/Localizations/de.lproj/Localizable.strings
+++ b/readeck/Localizations/de.lproj/Localizable.strings
@@ -46,6 +46,9 @@
 "General Settings" = "Allgemeine Einstellungen";
 "Server Settings" = "Server-Einstellungen";
 "Server Connection" = "Server-Verbindung";
+"Open external links in" = "Öffne externe Links in";
+"In App Browser" = "In App Browser";
+"Default Browser" = "Standard Browser";
 
 "Add" = "Hinzufügen";
 "Add new tag:" = "Neues Label hinzufügen:";
diff --git a/readeck/UI/Settings/SettingsGeneralView.swift b/readeck/UI/Settings/SettingsGeneralView.swift
index 197fc80..2f5a758 100644
--- a/readeck/UI/Settings/SettingsGeneralView.swift
+++ b/readeck/UI/Settings/SettingsGeneralView.swift
@@ -35,11 +35,11 @@ struct SettingsGeneralView: View {
             
             // Reading Settings
             VStack(alignment: .leading, spacing: 12) {
-                Text("Open external links in")
+                Text("Open external links in".localized)
                     .font(.headline)
                 Picker("urlOpener", selection: $viewModel.urlOpener) {
                     ForEach(UrlOpener.allCases, id: \.self) { urlOpener in
-                        Text(urlOpener.displayName).tag(urlOpener)
+                        Text(urlOpener.displayName.localized).tag(urlOpener)
                     }
                 }
                 .pickerStyle(.segmented)